Review main Merged

95363[BUGFIX] Use TypoScript from request in CObjectViewHelper

Rafael Kähm CR +2 V +2 Easy +2 −1 updated 08/24/26, 20:43

Commit message

The `CObjectViewHelper` currently retrieves `TypoScript` setup
directly from the `ConfigurationManager`.  This breaks the isolation
of indexing requests in EXT:solr, where a specific `TypoScript` context is expected.

Fix this by extracting the `TypoScript` from the request object provided
by the `renderingContext`. This ensures proper delegation of
`TypoScript` and context.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Till Hörner +1
    • Thomas Löffler +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Till Hörner +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Rafael Kähm uploaded patch set 1 08/18/26, 10:07

  2. core-ci voted on patch set 1 V +1 08/18/26, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106857

  3. Oliver Klee updated the commit message in patch set 2 V +1 08/18/26, 11:56

  4. core-ci voted on patch set 2 V +1 08/18/26, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106861

  5. Garvin Hicking voted on patch set 2 CR +1 08/18/26, 19:52

  6. Till Hörner voted on patch set 2 CR +1 V +1 08/19/26, 11:30

  7. Thomas Löffler voted on patch set 2 CR +1 08/19/26, 11:49

  8. Georg Ringer commented on patch set 2 CR +1 V +1 08/23/26, 14:33

    not sure if we should change that in 13.4 as well
  9. Garvin Hicking voted on patch set 2 CR +2 V +2 08/24/26, 18:24

  10. Garvin Hicking commented on patch set 2 08/24/26, 18:27

    Reply

    Talked to Benni about this, should be fine/needed.
  11. Garvin Hicking merged patch set 3 08/24/26, 20:43