Review main Merged

95364[BUGFIX] Use TypoScript from request in ConfirmationFinisher

Rafael Kähm CR +2 V +2 Easy +2 −1 updated 08/24/26, 20:44

Commit message

The `ConfirmationFinisher` currently retrieves `TypoScript` setup
directly from the `ConfigurationManager`.  This breaks the isolation
of indexing requests in EXT:solr, where a specific `TypoScript` context is expected.

Fix this by extracting the `TypoScript` from the request object provided
by the `finisherContext`.
This ensures proper delegation of `TypoScript` and context.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • Thomas Löffler +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Rafael Kähm uploaded patch set 1 08/18/26, 10:41

  2. core-ci voted on patch set 1 V +1 08/18/26, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106858

  3. Oliver Klee updated the commit message in patch set 2 V +1 08/18/26, 11:56

  4. core-ci voted on patch set 2 V +1 08/18/26, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106860

  5. Garvin Hicking voted on patch set 2 CR +1 08/18/26, 19:52

  6. Josua Vogel voted on patch set 2 CR +1 V +1 08/19/26, 06:11

  7. Thomas Löffler voted on patch set 2 CR +1 08/19/26, 12:20

  8. Garvin Hicking voted on patch set 2 CR +2 V +2 08/24/26, 18:23

  9. Garvin Hicking merged patch set 3 08/24/26, 20:44