95367[FEATURE] Show selected item counts for FormEngine item limits
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Daniel Windloff +1
-
Verified V +2 Done
- Garvin Hicking +2
- Daniel Windloff +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/Sass/component/forms/_form-wizard.scss+6 −0
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+3 −3
- Build/Sources/TypeScript/backend/form-engine/element/extra/item-count.tsnew+199 −0
- Build/Sources/TypeScript/backend/form-engine.ts+70 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/extra/item-count.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+2 −2
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-94886-ShowItemCountsInFormEngine.rst2new+38 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf2+18 −0
Review log 1724
-
Josua Vogel uploaded patch set 1 08/19/26, 07:54
-
core-ci voted on patch set 1 V -1 08/19/26, 08:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106883
-
Josua Vogel commented on patch set 2
V -108/19/26, 08:40Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 08/19/26, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106888
-
Josua Vogel uploaded patch set 3
V +108/19/26, 11:52 -
core-ci voted on patch set 3 V +1 08/19/26, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106893
-
Daniel Windloff commented on patch set 3 08/21/26, 08:25
It is a very nice feature 😊 Some remarks after testing: * For render type selectSingle a maximum number greater than 1 to select does not make any sense; therefore, it should not be displayed. * The default maximum number of 99999 could be confusing. For example, if a selectTree has only two elements, it seems wrong. I suggest removing the maximum if no proper maxitems configuration is set. * The label x elements selected do not fit for files or inline elements. It should be specific for these tca types. * For type input, the number of remaining characters is shown below the form element. I suggest using the same position here. * I would use the current title instead of only (1/5) as a label, as it explains the selection better.Feature-94886-ShowItemCountsInFormEngine.rst:15I suggest naming the TCA config > types and renderTypes here. -
Josua Vogel uploaded patch set 4
V +108/25/26, 14:39 -
core-ci voted on patch set 4 V +1 08/25/26, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107094
-
Josua Vogel commented on patch set 4 08/25/26, 14:53
Reply
DoneFeature-94886-ShowItemCountsInFormEngine.rst:15ReplyDone -
Garvin Hicking commented on patch set 4 08/25/26, 21:39
Feature-94886-ShowItemCountsInFormEngine.rst:27The changelog is missing an "Impact" section like other feature ReST files. IMO the changelog should also mention that any custom FormEngine Types that are built like selects will need to manually call the new AbstractFormElement `renderItemCountPlaceholder()`. This is what I find a bit unfortunate, that this patch will not apply it to any other custom selects. If we inject a webcomponent, it might be able to do its detection on whether a select or input group or whatever it is attached to, and then it could work on custom fields as well (which would be my UX/UI expectation). Thoughts?locallang_core.xlf:130It would be better to use speaking placeholders rather than numbers, to make translation more easy and understandable, so: ``` {actualItems}/{maxItems} (minimum {minItems}) ``` -
Garvin Hicking commented on patch set 4 08/25/26, 21:40
Review tip: Test with EXT:styleguide in `tx_styleguide_elements_select` and items `select_tree_7` / `select_tree_2` -
Josua Vogel uploaded patch set 5
V +108/26/26, 13:14 -
Josua Vogel commented on patch set 5 08/26/26, 13:29
Feature-94886-ShowItemCountsInFormEngine.rst:27ReplyDonelocallang_core.xlf:130ReplyDone -
core-ci voted on patch set 5 V +1 08/26/26, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107151
-
Josua Vogel uploaded patch set 6
V +109/03/26, 05:57 -
core-ci voted on patch set 6 V +1 09/03/26, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107718
-
Garvin Hicking voted on patch set 6 CR +1 V +1 09/03/26, 06:30
-
Josua Vogel uploaded patch set 7
CR +1V +109/03/26, 07:30 -
core-ci voted on patch set 7 V +1 09/03/26, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107724
-
Garvin Hicking voted on patch set 7 CR +1 V +1 09/03/26, 07:37
-
Daniel Windloff voted on patch set 7 CR +1 V +1 09/04/26, 06:20
-
Garvin Hicking voted on patch set 7 CR +2 V +2 09/04/26, 06:38
-
Garvin Hicking merged patch set 8 09/04/26, 06:38