95369[TASK] Use permalinks for documentation URLs
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Kott +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 25
- Build/git-hooks/unix+mac/pre-commit+4 −4
- Build/git-hooks/commit-msg+1 −1
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php+1 −1
- typo3/sysext/backend/Resources/Private/tsref.xml+3 −3
- typo3/sysext/core/Classes/Authentication/JsConfirmation.php+1 −1
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+2 −2
- typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilder/LikeTest.php+2 −2
- typo3/sysext/core/Tests/Unit/TypoScript/TypoScriptServiceTest.php+1 −1
- typo3/sysext/dashboard/Configuration/Services.yaml+4 −4
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+3 −3
- typo3/sysext/extensionmanager/README.rst+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php+1 −1
- typo3/sysext/form/Documentation/D/Events/Index.rst+2 −2
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php+1 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowInstallerNotAvailable.fluid.html+2 −2
- typo3/sysext/install/Resources/Private/Templates/Maintenance/Cards.fluid.html+2 −1
- typo3/sysext/install/Resources/Private/Templates/Maintenance/LanguagePacks.fluid.html+3 −4
- typo3/sysext/install/Resources/Private/Templates/Upgrade/Cards.fluid.html+2 −1
- typo3/sysext/install/Resources/Private/Templates/Upgrade/ExtensionScanner.fluid.html+2 −4
- typo3/sysext/styleguide/README.md+2 −2
Review log 1722
-
Elias Häußler uploaded patch set 1 08/19/26, 17:30
-
Elias Häußler uploaded patch set 2 08/19/26, 17:31
-
core-ci voted on patch set 1 V +1 08/19/26, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106896
-
core-ci voted on patch set 2 V +1 08/19/26, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106897
-
Garvin Hicking commented on patch set 2 CR +1 V +1 08/19/26, 19:47
Thanks! Backport note... we could set @14 and @13 version references to go to the relevant branch parts. However then when main becomes v15 release we would neef to change it. So I'd also be fine with links going to main for all. -
Elias Häußler commented on patch set 2 08/20/26, 10:13
Reply
I haven't considered a backport for this patch. Do you think it is worth backporting to v14/v13? -
Garvin Hicking commented on patch set 2 08/20/26, 11:14
Reply
Just wanted to mention it if it might get backported. I would be fine either way, no preference on my side -
Sebastian Fischer voted on patch set 2 CR +1 08/20/26, 11:31
-
Benjamin Kott uploaded patch set 3
CR +1V +108/25/26, 10:34 -
Benjamin Kott commented on patch set 3 08/25/26, 10:34
Reply
we need to backport this, added the documentation link helper where possible -
core-ci voted on patch set 3 V +1 08/25/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107079
-
Benjamin Kott uploaded patch set 4
V +108/25/26, 10:43 -
Benjamin Kott voted on patch set 4 CR +1 V +1 08/25/26, 10:43
-
core-ci voted on patch set 4 V +1 08/25/26, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107080
-
Garvin Hicking commented on patch set 4 CR +1 V +1 08/25/26, 20:52
Thanks for this! There are a few places that should also be addressed: ``` typo3/sysext/core/Classes/Authentication/JsConfirmation.php:25 SECURITY.md:71 typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilder/LikeTest.php:134 typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilder/LikeTest.php:378 typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php:195 typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php:216 typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php:531 typo3/sysext/workspaces/Documentation/Introduction/Index.rst:30 ``` This can be a follow-up if you want. Sadly I am lacking the time to adjust the places above myself.guides.xml:12ooops -
Benjamin Kott uploaded patch set 5
CR +1V +108/25/26, 22:16 -
Benjamin Kott voted on patch set 5 CR +1 V +1 08/25/26, 22:17
-
Garvin Hicking voted on patch set 5 CR +1 V +1 08/25/26, 22:20
-
core-ci voted on patch set 5 V +1 08/25/26, 22:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107100
-
Benjamin Kott voted on patch set 5 CR +2 V +2 08/25/26, 23:27
-
Benjamin Kott merged patch set 6 08/25/26, 23:53