Review main Merged

9537[BUGFIX] html5 rendering does handle non-xml documents

Steffen Ritter CR +2 V +2 Easy +10 −2 updated 06/03/13, 20:49

Commit message

When selecting html5 in config.doctype and deactivating
config.xmlprologue = none the xmlns-attribute of <html> has
to be omitted and the xhtml-cleaning has to be deactivated.

Furthermore the non XML-Syntax of the charset meta-tag has to
be provided to the renderer.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Jigal van Hemert +1
    • Ingo Pfennigstorf +1
  • Verified V +2
    • Steffen Ritter +2
    • Jigal van Hemert +1
    • Ingo Pfennigstorf +1

Files 1

Review log 10

  1. Stefan Neufeind commented on patch set 2 03/13/12, 11:55

    Looks good to me, but someone else must approve Looks okay by reading explanation and code
  2. Steffen Ritter uploaded patch set 2 03/13/12, 11:55

  3. Steffen Ritter commented on patch set 2 03/13/12, 11:55

    Hi Jigal, for exactly your usecase config.doctype_switch has been introduced, which just flips <xml> and <! doctype> around. Outputting a XHTML document without xmlprologue in no way is valid, therefore this IS an indicator if it is an xml document. Furthermore as soon as you output a non-valid document because IE6 does not support otherwise it is not valid anyhow - who then cares about xhtml_cleaning? And last: IE6? Wo cares...
  4. Jigal van Hemert commented on patch set 2 03/13/12, 11:55

    I would prefer that you didn't submit this IE6 will use quirks mode if anything precedes the doctype. To have XHTML in standards mode in IE6 it's common practise to set xmlprologue = none and htmlTag_setParams = none How would you output an XHTML document without xml prologue if you set xmlprologue=none ?
  5. Jigal van Hemert commented on patch set 2 03/13/12, 11:55

    Verified; Looks good to me, but someone else must approve Yes, doctype_switch can fix the situation for IE6; I forgot about that option. It's mostly done with a condition just for IE6 and this browser has some unorthodox ideas about document structures... > And last: IE6? Wo cares... It seems that we still care; it was the reason for having an LTS version. Besides, its market share is 50% larger than that of IE7. Anyway, with doctype_switch this is a good solution.
  6. Ingo Pfennigstorf commented on patch set 2 03/13/12, 11:55

    Verified; Looks good to me, but someone else must approve Got rid of xml / xhtml parts in the document and validator is not complainig about these parts anymore
  7. Mr. Jenkins commented on patch set 1 03/13/12, 11:55

  8. Mr. Jenkins commented on patch set 2 03/13/12, 11:55

  9. Steffen Ritter commented on patch set 2 V 0 03/13/12, 11:55

    by team member; Looks good to me, approved
  10. Steffen Ritter merged patch set 2 03/13/12, 11:55