Review 14.3 Abandoned

95373[BUGFIX] Use BackendUtility::getRecordTitle() in PageLinkMessageProvider

Steffen Mächtel CR -1 V 0 Easy +2 −1 updated 08/23/26, 21:06

Commit message

Pages with doktype "link" and a link target containing a numeric
fragment (e.g. `t3://page?uid=1020#3727`) cause a
`RecordPropertyNotFoundException` in the backend layout module.

`PageLinkMessageProvider::generateLinkToContentElement()` resolves
the fragment as a content element uid and calls
`$record->get('header')` directly. In TYPO3 v14, the `Record`
class only exposes properties defined in the CType's TCA `types`
showitem. Custom CTypes that do not include `header` in their
showitem therefore throw an exception.

Replace the direct `get()` call with
`BackendUtility::getRecordTitle()`, which reads the TCA `label`
configuration and falls back gracefully when fields are unavailable.
This is consistent with how `getMessageForPageTypeLinkToRecord()`
already resolves record labels in the same class.

Review

  • Code review CR -1
    • Wouter Wolters -1
    • Sebastian Fischer +1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Steffen Mächtel uploaded patch set 1 08/20/26, 16:09

  2. core-ci voted on patch set 1 V +1 08/20/26, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106918

  3. Sebastian Fischer voted on patch set 1 CR +1 08/21/26, 08:49

  4. Wouter Wolters commented on patch set 1 CR -1 08/21/26, 11:26

    main should go first and the backport should have the same change-id as the patch for main. That is not the case now. The normal flow is push the change to main. A maintainer will take care of the backport.
  5. Steffen Mächtel abandoned the change 08/23/26, 21:02

  6. Steffen Mächtel commented on patch set 1 08/23/26, 21:06

    Reply Unresolved

    Oh ok sorry. I have abandoned change #95373. The only remaining change on the main branch is #95374.