Review main Merged

95375[BUGFIX] Build a blank form from the blank start template

Maike Kiebele CR +2 V +2 Normal +96 −5 updated 08/25/26, 11:27

Commit message

The "create new form" wizard lets editors pick "Blank" or "Predefined"
in step 1. Only the predefined mode shows a start template selection;
blank mode shows none, yet the wizard still submitted whichever template
was configured first. Where an integrator had not put the blank template
first, choosing "Blank" produced a predefined form.

Which template a blank form is built from is not something the client
can know: newFormTemplates is an ordered list that marks none of its
entries as the blank one. The settings step therefore only picks a
template where it offers one, and FormManagerController resolves the
blank form shipped by EXT:form when a form is created without one. A
template path a client does name is still held against newFormTemplates
as before.

The order of newFormTemplates no longer decides what a blank form
contains. BeforeFormIsCreatedEvent is the way to change what a newly
created form starts from.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 911

  1. Maike Kiebele uploaded patch set 1 08/21/26, 10:37

  2. core-ci voted on patch set 1 V +1 08/21/26, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106946

  3. Josua Vogel commented on patch set 1 CR +1 V +1 08/23/26, 17:46

    Thx Maike 😊 LGTM btw: my feature request https://review.typo3.org/c/Packages/TYPO3.CMS/+/95015 makes it “superfluous”
  4. Georg Ringer voted on patch set 1 CR +1 V +1 08/24/26, 05:35

  5. Benjamin Kott uploaded patch set 2 CR +1 V +1 08/24/26, 09:06

  6. Benjamin Kott commented on patch set 2 08/24/26, 09:07

    i reduced the js side to only submit empty string as no template used, the php side will handle this now, seems to be the better choice for further optimizations on the php side.
  7. Benjamin Kott voted on patch set 2 CR +1 V +1 08/24/26, 09:08

  8. core-ci voted on patch set 2 V +1 08/24/26, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107018

  9. Josua Vogel voted on patch set 2 CR +1 V +1 08/25/26, 08:13

  10. Benjamin Kott voted on patch set 2 CR +2 V +2 08/25/26, 10:45

  11. Benjamin Kott merged patch set 3 08/25/26, 11:27