Review main Merged

95379[TASK] Improve history correlation lookup performance

Wouter Wolters CR +2 V +2 Easy +2 −1 updated 10/10/26, 10:22

Commit message

Record history lookups filter entries by correlation_id and order them
by tstamp. Add a matching composite index to avoid full table scans and
additional sorting as the history table grows.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Wouter Wolters uploaded patch set 1 08/21/26, 20:55

  2. core-ci voted on patch set 1 V +1 08/21/26, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106951

  3. Oliver Klee voted on patch set 1 CR +1 08/22/26, 07:25

  4. Benni Mack commented on patch set 1 09/04/26, 12:12

    ext_tables.sql:195

    I think we should limit this to correlation_id(20) ?
  5. Wouter Wolters commented on patch set 1 09/07/26, 19:12

    ext_tables.sql:195 Reply

    A prefix index would work, but the first 20 characters only cover the flags and part of the scope. Since the scope is shared across a DataHandler operation, the index would no longer distinguish its individual subjects or aspects. I’d prefer keeping the full composite index for this exact lookup, unless benchmarks show a benefit from shortening it
  6. Benni Mack commented on patch set 1 CR +2 V +2 10/10/26, 10:22

    ext_tables.sql:195 Reply

    Done
  7. Benni Mack merged patch set 2 10/10/26, 10:22