Review main Merged

95380[TASK] Improve dashboard lookup and identifier integrity

Wouter Wolters CR +2 V +2 Hard +337 −3 updated 10/12/26, 18:18

Commit message

Dashboard identifiers based on presets and second-level timestamps can
collide. Use the Random API to generate identifiers and enforce
uniqueness in the database. Migrate existing duplicates, including
deleted, hidden and scheduled dashboards.

Schema updates can run before upgrade wizards. Defer the unique index
while duplicate identifiers exist so the initial schema update does not
fail with a constraint violation. After deduplication, run the database
analyzer again to create the unique index.

Index cruser_id to avoid full table scans when loading a user's
dashboards.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1113

  1. Wouter Wolters uploaded patch set 1 08/21/26, 20:58

  2. core-ci voted on patch set 1 V +1 08/21/26, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106952

  3. Oliver Klee voted on patch set 1 CR +1 V +1 08/22/26, 07:26

  4. Benni Mack commented on patch set 1 09/23/26, 22:50

    DashboardRepository.php:86

    please see Random.php and its usages.
  5. Benni Mack commented on patch set 1 09/23/26, 22:50

  6. Wouter Wolters uploaded patch set 2 CR +1 V +1 09/30/26, 17:35

  7. Wouter Wolters commented on patch set 1 09/30/26, 17:35

    Some statistics for the index. | Dashboard rows | Without index | With index | |---:|---:|---:| | 10,000 | 0\.3045 ms | 0\.0042 ms | | 100,000 | 4\.6708 ms | 0\.0045 m |

    Reply

    This change is unrelated to mine. I think 93974 is not needed at all.

    DashboardRepository.php:86 Reply

    Done
  8. Wouter Wolters commented on patch set 2 09/30/26, 17:36

    Reply

    Done
  9. core-ci voted on patch set 2 V +1 09/30/26, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109682

  10. Benni Mack voted on patch set 2 CR +1 V +1 10/10/26, 15:02

  11. Guido Schmechel voted on patch set 2 CR +1 V +1 10/12/26, 17:48

  12. Georg Ringer voted on patch set 2 CR +2 V +2 10/12/26, 18:18

  13. Georg Ringer merged patch set 3 10/12/26, 18:18