Review main Merged

95385[TASK] Add image information to system resources

Helmut Hummel CR +2 V +2 Hard +294 −2 updated 08/28/26, 09:16

Commit message

Allow system resources to report whether they reference an image and
provide the detected image dimensions.

Package resources use the existing file and image information APIs to
detect the image type and dimensions. Detected dimensions are cached
for subsequent access.

Resources without a file extension now return an empty extension
instead of accessing an undefined path information key.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 1216

  1. Helmut Hummel uploaded patch set 1 08/22/26, 17:46

  2. core-ci voted on patch set 1 V -1 08/22/26, 17:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106970

  3. Helmut Hummel uploaded patch set 2 V -1 08/23/26, 06:15

  4. core-ci voted on patch set 2 V -1 08/23/26, 06:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106983

  5. Helmut Hummel uploaded patch set 3 V -1 08/23/26, 07:30

  6. core-ci voted on patch set 3 V +1 08/23/26, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106984

  7. Sebastian Fischer voted on patch set 3 CR +1 08/24/26, 06:29

  8. Oliver Klee voted on patch set 3 CR +1 V +1 08/24/26, 11:08

  9. Oliver Klee commented on patch set 3 CR -1 08/24/26, 11:11

    The issue ID is missing.

    SystemResourceInterface.php:46

    Let's have a blank line between the methods: ```suggestion /** ```
  10. Helmut Hummel uploaded patch set 4 CR +1 V +1 08/28/26, 07:45

  11. Helmut Hummel commented on patch set 3 08/28/26, 07:45

    SystemResourceInterface.php:46 Reply

    Done
  12. core-ci voted on patch set 4 V +1 08/28/26, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107318

  13. Georg Ringer voted on patch set 4 CR +1 V +1 08/28/26, 08:05

  14. Stefan Bürk commented on patch set 4 CR +1 V +1 08/28/26, 08:25

    Reply

    Done
  15. Helmut Hummel voted on patch set 4 CR +2 V +2 08/28/26, 09:12

  16. Helmut Hummel merged patch set 5 08/28/26, 09:16