95385[TASK] Add image information to system resources
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Georg Ringer +1
- Stefan Bürk +1
-
Verified V +2 Done
- Helmut Hummel +2
- Georg Ringer +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/core/Classes/Resource/File.php+16 −0
- typo3/sysext/core/Classes/SystemResource/Exception/CanNotDetectImageDimensionOfSystemResourceException.phpnew+24 −0
- typo3/sysext/core/Classes/SystemResource/Type/PackageResource.php+61 −2
- typo3/sysext/core/Classes/SystemResource/Type/SystemResourceInterface.php2+13 −0
- typo3/sysext/core/Tests/Unit/SystemResource/Type/Fixtures/test-broken.pngnewbinary
- typo3/sysext/core/Tests/Unit/SystemResource/Type/Fixtures/test.pngnewbinary
- typo3/sysext/core/Tests/Unit/SystemResource/Type/PackageResourceTest.phpnew+180 −0
Review log 1216
-
Helmut Hummel uploaded patch set 1 08/22/26, 17:46
-
core-ci voted on patch set 1 V -1 08/22/26, 17:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106970
-
Helmut Hummel uploaded patch set 2
V -108/23/26, 06:15 -
core-ci voted on patch set 2 V -1 08/23/26, 06:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106983
-
Helmut Hummel uploaded patch set 3
V -108/23/26, 07:30 -
core-ci voted on patch set 3 V +1 08/23/26, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106984
-
Sebastian Fischer voted on patch set 3 CR +1 08/24/26, 06:29
-
Oliver Klee voted on patch set 3 CR +1 V +1 08/24/26, 11:08
-
Oliver Klee commented on patch set 3 CR -1 08/24/26, 11:11
The issue ID is missing.SystemResourceInterface.php:46Let's have a blank line between the methods: ```suggestion /** ``` -
Helmut Hummel uploaded patch set 4
CR +1V +108/28/26, 07:45 -
Helmut Hummel commented on patch set 3 08/28/26, 07:45
SystemResourceInterface.php:46ReplyDone -
core-ci voted on patch set 4 V +1 08/28/26, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107318
-
Georg Ringer voted on patch set 4 CR +1 V +1 08/28/26, 08:05
-
Stefan Bürk commented on patch set 4 CR +1 V +1 08/28/26, 08:25
Reply
Done -
Helmut Hummel voted on patch set 4 CR +2 V +2 08/28/26, 09:12
-
Helmut Hummel merged patch set 5 08/28/26, 09:16