Review main Merged

95392[BUGFIX] Fix null access when marking invalid stage items

Josua Vogel CR +2 V +2 Easy +2 −2 updated 08/25/26, 11:12

Commit message

The form editor validates all form elements recursively and tries to
mark invalid form elements in the stage view. For elements on pages that
are not currently rendered, the stage DOM lookup returns null. This
caused a TypeError when the validation result was processed.

Add a null check before accessing the stage item element so invalid
elements on hidden pages are ignored gracefully and the editor remains
usable.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Sebastian Fischer +1
    • Ravi Sachaniya +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Ravi Sachaniya +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Josua Vogel uploaded patch set 1 08/23/26, 17:40

  2. Josua Vogel updated the commit message in patch set 2 08/23/26, 17:40

  3. core-ci voted on patch set 2 V +1 08/23/26, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106999

  4. core-ci voted on patch set 1 V +1 08/23/26, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106998

  5. Oliver Klee updated the commit message in patch set 3 V +1 08/23/26, 21:33

  6. core-ci voted on patch set 3 V +1 08/23/26, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107000

  7. Sebastian Fischer voted on patch set 3 CR +1 08/24/26, 06:20

  8. Ravi Sachaniya voted on patch set 3 CR +1 V +1 08/25/26, 10:09

  9. Benjamin Kott voted on patch set 3 CR +2 V +2 08/25/26, 10:56

  10. Benjamin Kott merged patch set 4 08/25/26, 11:12