Review main Merged

95393[BUGFIX] Import page translations onto their parent page

Benjamin Kott CR +2 V +2 Normal +97 −1 updated 10/15/26, 08:35

Commit message

The export appends page translations to the exported page tree as top
level nodes, purely to mark them as being part of that tree. The import
reads the same section as a real tree and reverses each level, so a
translation was written before the page it belongs to had been assigned
its new ID. The parent lookup missed and the translation was created on
the import target instead of next to its default language page.

The pages are now ordered so that every page is written after its
parent page. The file format stays untouched, so already exported
files import correctly as well.

A functional import test for a multilingual page tree is added, which
was missing so far and let the export and import sides drift apart.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 79

  1. Benjamin Kott uploaded patch set 1 08/24/26, 10:59

  2. Benjamin Kott updated the commit message in patch set 2 08/24/26, 10:59

  3. core-ci voted on patch set 1 V +1 08/24/26, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107025

  4. core-ci voted on patch set 2 V +1 08/24/26, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107026

  5. Benni Mack voted on patch set 2 CR +1 V +1 09/02/26, 05:57

  6. Georg Ringer voted on patch set 2 CR +1 V +1 09/02/26, 18:34

  7. Benjamin Kott voted on patch set 2 CR +2 V +2 09/02/26, 21:20

  8. Benjamin Kott merged patch set 3 09/02/26, 21:59

  9. Garvin Hicking wrote 10/15/26, 08:35

    Hashtag added: no-backport