Review main Abandoned

95398[TASK] Switch YAML indentation from 2 to 4 spaces

Oliver Klee CR -1 V 0 Impossible +5176 −5244 updated 09/29/26, 13:48

Commit message

This makes the indentation of YAML files consistent with most
other files, while there is no good reason for it to be
different.

Also, this makes the indentation easier to see.

Review

  • Code review CR -1
    • Andreas Kienast -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 112

Show 92 more files

Review log 79

  1. Oliver Klee uploaded patch set 1 08/24/26, 16:31

  2. core-ci voted on patch set 1 V -1 08/24/26, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107043

  3. Oliver Klee uploaded patch set 2 V -1 08/24/26, 16:52

  4. core-ci voted on patch set 2 V +1 08/24/26, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107044

  5. Andreas Kienast commented on patch set 2 CR -1 08/25/26, 05:23

    LoadInvalidYaml.yaml:5 Unresolved

    This looks somewhat broken now, the indentation is not aligned with the values down below.

    config1.yaml:4 Unresolved

    I'm not a big fan of this kind of structure, the three spaces between the dash and the entry _look_ arbitrary.
  6. Oliver Klee commented on patch set 2 08/25/26, 12:45

    Hm, maybe it would also make sense for me to split this up into several smaller changes …
  7. Oliver Klee wrote 08/25/26, 15:21

    Removed reviewer Helmut Hummel.
  8. Oliver Klee marked it work in progress 08/25/26, 15:21

  9. Oliver Klee abandoned the change 09/29/26, 13:48