Review main Merged

95399[BUGFIX] Apply addQueryString.exclude to linkVars

Benjamin Kott CR +2 V +2 Normal +131 −5 updated 09/04/26, 11:57

Commit message

Both addQueryString and config.linkVars carry query parameters of the
current request over into generated page links, but
addQueryString.exclude only removed a parameter from the former. A
parameter listed in config.linkVars was merged back in afterwards and
could therefore not be dropped from a link at all.

The exclude list is now applied to the parameters contributed by
config.linkVars as well, but only while addQueryString is active, so
config.linkVars on its own keeps its behaviour.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Benjamin Kott uploaded patch set 1 08/24/26, 17:19

  2. core-ci voted on patch set 1 V +1 08/24/26, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107045

  3. Georg Ringer voted on patch set 1 CR +1 V +1 08/24/26, 18:53

  4. Benni Mack voted on patch set 1 CR +2 V +2 09/04/26, 11:57

  5. Benni Mack merged patch set 2 09/04/26, 11:57