Review main Merged

95406[BUGFIX] Hide password generator without a usable policy

Benjamin Kott CR +2 V +2 Normal +124 −4 updated 08/27/26, 15:31

Commit message

The "generate password" field control rendered whenever a password
field declared it, including when the password policy it needs was
unset, unknown, or carried no generator at all. The generator is
resolved from that policy, so in each of those cases every click
failed and the editor was left with a button that does nothing.

An installation reaches this by disabling password policies, since
the core TCA of be_users and fe_users passes BE/passwordPolicy and
FE/passwordPolicy straight into the control, and an empty value
leaves the generator unresolvable.

The control now renders nothing when no generator can be resolved,
which the field control API allows by returning an empty result.
PasswordGeneratorController keeps the authoritative check: it also
verifies the class and its interface, and logs what it rejects.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Josua Vogel +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Josua Vogel +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 56

  1. Benjamin Kott uploaded patch set 1 08/24/26, 20:38

  2. core-ci voted on patch set 1 V +1 08/24/26, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107056

  3. Josua Vogel voted on patch set 1 CR +1 V +1 08/26/26, 14:01

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 08/27/26, 06:32

  5. Benjamin Kott voted on patch set 1 CR +2 V +2 08/27/26, 13:23

  6. Benjamin Kott merged patch set 2 08/27/26, 15:31