Review main Merged

95408[TASK] Harden localization wizard endpoints

Benjamin Kott CR +2 V +2 Normal +155 −62 updated 09/02/26, 21:39

Commit message

Of the seven localization wizard AJAX endpoints, only getModes(),
getTargets() and getSources() verified that the backend user may access
the page a record lives on. getRecord(), getHandlers(), getContent() and
localize() carried no check, so they answered for any authenticated
backend user. All four now apply the same rule; localize() keeps
DataHandler as the authority and gains the check as a second barrier
only.

Four of the five wizard steps caught a failed request inside their own
task and returned an empty list, which rendered the regular "nothing
available" message. That made a denied request indistinguishable from an
empty result and left the error branch each step declares unreachable.
Those steps now let the failure surface, so the wizard renders the error
it always carried a label for, keeps its progress bar and buttons,
refuses to advance and still allows a step back.
ContentRecordSelectionStep already behaved this way.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 68

  1. Benjamin Kott uploaded patch set 1 08/24/26, 22:46

  2. core-ci voted on patch set 1 V +1 08/24/26, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107059

  3. Benjamin Kott rebased onto patch set 2 V +1 09/02/26, 19:13

  4. core-ci voted on patch set 2 V +1 09/02/26, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107671

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 09/02/26, 19:31

  6. Benni Mack voted on patch set 2 CR +1 V +1 09/02/26, 19:39

  7. Benjamin Kott voted on patch set 2 CR +2 V +2 09/02/26, 21:20

  8. Benjamin Kott merged patch set 3 09/02/26, 21:39