Review main Merged

95413[BUGFIX] Make CGL suites work in git worktrees

Benjamin Kott CR +2 V +2 Easy +39 −6 updated 08/31/26, 12:33

Commit message

In a git worktree ".git" is a file pointing to a gitdir outside the
core root. runTests.sh mounts only the core root into the container,
so git has no repository to read there and neither cglGit nor
cglHeaderGit find any file to check.

The container now additionally mounts the common gitdir under its
original absolute path whenever ".git" is a file, which also covers
the worktree gitdir nested below it.

That alone would have stayed unnoticed much longer, because
cglFixMyCommit.sh piped git into grep and therefore only ever saw
grep's exit status. A failing git call produced an empty file list,
which the script reported as "all is well" before exiting with zero.
Both scripts now evaluate the git call on its own and abort with a
message instead of claiming success.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benjamin Kott uploaded patch set 1 08/25/26, 11:41

  2. core-ci voted on patch set 1 V +1 08/25/26, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107088

  3. Benjamin Kott rebased onto patch set 2 V +1 08/31/26, 11:24

  4. core-ci voted on patch set 2 V +1 08/31/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107420

  5. Stefan Bürk voted on patch set 2 CR +2 V +2 08/31/26, 11:46

  6. Stefan Bürk commented on patch set 2 08/31/26, 11:47

    Going this as tooling only without full review votes.
  7. Stefan Bürk merged patch set 3 08/31/26, 12:33