95422[BUGFIX] Support `f:render.text` for backend rich text
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Simon Praetorius +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Garvin Hicking +2
- Simon Praetorius +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1921
-
Matthias Vogel uploaded patch set 1 08/26/26, 11:13
-
core-ci voted on patch set 1 V +1 08/26/26, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107133
-
Matthias Vogel marked it ready for review 08/26/26, 11:20
-
Oli Bartsch commented on patch set 1 08/26/26, 11:38
-
Matthias Vogel commented on patch set 1 08/26/26, 11:40
TextViewHelper.php:207ReplyIt is still 'Format\HtmlViewHelper'; it's just a class alias in this file to distinguish between the 3 HtmlViewHelpers. -
Simon Praetorius commented on patch set 1 CR +1 V +1 08/26/26, 11:41
tested in a v14 project -
Matthias Vogel commented on patch set 1 08/26/26, 11:52
TextViewHelper.php:207ReplyDone -
Garvin Hicking commented on patch set 1 08/26/26, 22:06
TextViewHelper.php:204Did you by chance measure performance impact if this is run many times for many fields? Maybe using a runtime cache for the result of this could be useful, if it's impactful? -
Matthias Vogel commented on patch set 1 08/27/26, 07:22
TextViewHelper.php:204ReplyIt is the same code as it is inside the Format\HtmlViewHelper. I measured that condition part: ~0.0025 ms per invocation. so we can run that part 400k times per second :) I think we do not have a Problem here. -
Garvin Hicking commented on patch set 1 CR +1 08/27/26, 07:49
TextViewHelper.php:204ReplyAcknowledged -
Nikita Hovratov commented on patch set 1 08/27/26, 08:53
TextViewHelper.php:212I think we can get rid of this else with early return -
Nikita Hovratov voted on patch set 1 V +1 08/27/26, 09:05
-
Nikita Hovratov commented on patch set 1 08/27/26, 09:06
TextViewHelper.php:212Reply(not blocking) -
Nikita Hovratov commented on patch set 1 08/27/26, 09:06
TextViewHelper.php:212ReplyDone -
Matthias Vogel uploaded patch set 2
CR +1V +108/27/26, 09:45 -
Garvin Hicking voted on patch set 2 CR +1 08/27/26, 09:49
-
Nikita Hovratov voted on patch set 2 CR +1 V +1 08/27/26, 09:49
-
Simon Praetorius voted on patch set 2 CR +1 V +1 08/27/26, 10:01
-
core-ci voted on patch set 2 V +1 08/27/26, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107245
-
Garvin Hicking voted on patch set 2 CR +2 V +2 08/27/26, 14:55
-
Garvin Hicking merged patch set 3 08/27/26, 14:55
TextViewHelper.php:207