Review main Merged

95424[TASK] Enable strictFunctionTypes for the TypeScript build

Benjamin Kott CR +2 V +2 Expert +712 −588 updated 10/09/26, 19:10

Commit message

Without strictFunctionTypes a callback may declare narrower parameter
types than its caller passes, so such mismatches go unnoticed.

Most errors the option reports are fixed where the value is produced:
querySelectorAll() is called with a type argument and custom events are
registered in HTMLElementEventMap and DocumentEventMap. The annotations
this makes redundant in the callbacks are dropped.

Three install tool response types were wrong and now declare numbers,
which need an explicit string conversion. Apart from that the build
output is unchanged.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 172

Show 152 more files

Review log 68

  1. Benjamin Kott uploaded patch set 1 08/26/26, 13:09

  2. core-ci voted on patch set 1 V +1 08/26/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107137

  3. Benjamin Kott marked it work in progress 08/26/26, 13:24

  4. Benjamin Kott uploaded patch set 2 V +1 10/09/26, 17:53

  5. core-ci voted on patch set 2 V +1 10/09/26, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110663

  6. Benni Mack voted on patch set 2 CR +1 V +1 10/09/26, 18:42

  7. Benjamin Kott voted on patch set 2 CR +2 V +2 10/09/26, 19:09

  8. Benjamin Kott merged patch set 3 10/09/26, 19:10