Review main Merged

95426[TASK] Guard nullable values in backend modules

Benjamin Kott CR +2 V +2 Hard +147 −123 updated 11/19/26, 08:58

Commit message

In the admin panel and in the modules for backend users, reactions,
recycler, redirects, scheduler and workspaces, a value the types
report as possibly missing is guarded or given a fallback. This
prepares for strictNullChecks; the modules behave the same with the
markup they are rendered with.

Values the module's own markup guarantees get a non-null assertion
once strictNullChecks is enabled, as no-unnecessary-type-assertion
reports every such assertion until then.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 38

Show 18 more files

Review log 1624

  1. Benjamin Kott uploaded patch set 1 08/26/26, 13:09

  2. core-ci voted on patch set 1 V +1 08/26/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107139

  3. Benjamin Kott marked it work in progress 08/26/26, 13:24

  4. Benjamin Kott uploaded patch set 2 V +1 10/15/26, 16:16

  5. core-ci voted on patch set 2 V +1 10/15/26, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111228

  6. Benjamin Kott updated the commit message in patch set 3 V +1 10/15/26, 21:02

  7. Benjamin Kott commented on patch set 3 10/15/26, 21:03

    This change is ready for review.
  8. core-ci voted on patch set 3 V +1 10/15/26, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111269

  9. Benjamin Kott rebased onto patch set 4 V +1 10/16/26, 07:45

  10. core-ci voted on patch set 4 V -1 10/16/26, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111317

  11. Benjamin Kott rebased onto patch set 5 V -1 10/16/26, 09:26

  12. core-ci voted on patch set 5 V +1 10/16/26, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111332

  13. Benjamin Kott uploaded patch set 6 V +1 10/23/26, 14:49

  14. core-ci voted on patch set 6 V -1 10/23/26, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112324

  15. Benjamin Kott uploaded patch set 7 V -1 10/23/26, 15:42

  16. Benjamin Kott marked it work in progress 10/23/26, 15:49

  17. core-ci voted on patch set 7 V -1 10/23/26, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112344

  18. Benjamin Kott uploaded patch set 8 V -1 11/18/26, 10:59

  19. core-ci voted on patch set 8 V +1 11/18/26, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114856

  20. Benjamin Kott commented on patch set 8 11/18/26, 17:34

    This change is ready for review.
  21. Benni Mack voted on patch set 8 CR +1 V +1 11/18/26, 17:39

  22. Benjamin Kott voted on patch set 8 CR +2 V +2 11/18/26, 17:50

  23. Benjamin Kott merged patch set 9 11/18/26, 18:09

  24. Ayke Halder commented on patch set 9 11/19/26, 08:58

    preview.ts:18 Unresolved

    This should be fixed to ```suggestion this.targetField = document.getElementById(this.dateField.dataset.bsTarget ?? '') as HTMLInputElement | null; ```

    preview.ts:21 Unresolved

    This must be ```suggestion if (this.targetField?.value) { ```