Review main Merged

95428[TASK] Make the file list and the RTE null-safe

Benjamin Kott CR +2 V +2 Normal +119 −111 updated 11/19/26, 08:25

Commit message

Fourth step towards strictNullChecks, covering filelist and
rte_ckeditor. With this every extension except backend, form and
install is done.

The file list mostly reads a resource that carries a nullable uid,
metaUid, url and size, and passed those on as if they were always
there. Where a caller genuinely tolerates the absence, the signature
now says so, which is why the context menu, the element browser and
the icon API gained a nullable parameter rather than every call site
gaining a cast. `FileListActionDetail.event` was declared as an Event
although the context menu actions have always dispatched it as null.
The element browser no longer inserts a file it cannot identify by
its uid.

The RTE mostly talks to CKEditor 5, whose API returns null or
undefined in many places the plugin treats as certain: a command that
may not be registered, a selection that may be empty, a marker that
may not resolve. Where the plugin's own contract guarantees the value,
it is left for the non-null assertion; where it can be missing, the
plugin falls back, such as the link balloon attaching to the selection
when the highlight marker has no view elements.

One thing is deliberately left as it is. The editable element styles
read `Number(assignment)` before `assignment` is assigned, so a
numeric string never reached the branch appending `px`. The dead
condition is removed and the behaviour kept, with a note - correcting
it changes the rendered size and belongs in its own change.

The non-null assertions this step relies on are added with
strictNullChecks itself, as no-unnecessary-type-assertion reports
every such assertion until the option is enabled.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 33

Show 13 more files

Review log 1322

  1. Benjamin Kott uploaded patch set 1 08/26/26, 13:09

  2. Benjamin Kott marked it work in progress 08/26/26, 13:23

  3. core-ci voted on patch set 1 V +1 08/26/26, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107141

  4. Benjamin Kott uploaded patch set 2 V +1 10/15/26, 16:16

  5. core-ci voted on patch set 2 V +1 10/15/26, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111230

  6. Benjamin Kott updated the commit message in patch set 3 V +1 10/15/26, 21:02

  7. core-ci voted on patch set 3 V -1 10/15/26, 21:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111271

  8. Benjamin Kott rebased onto patch set 4 V -1 10/16/26, 07:45

  9. core-ci voted on patch set 4 V -1 10/16/26, 08:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111319

  10. Benjamin Kott rebased onto patch set 5 V -1 10/16/26, 09:26

  11. core-ci voted on patch set 5 V +1 10/16/26, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111334

  12. Benjamin Kott uploaded patch set 6 V +1 10/23/26, 14:49

  13. core-ci voted on patch set 6 V -1 10/23/26, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112326

  14. Benjamin Kott uploaded patch set 7 V -1 10/23/26, 15:42

  15. core-ci voted on patch set 7 V -1 10/23/26, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112346

  16. Benjamin Kott rebased onto patch set 8 V -1 11/18/26, 10:59

  17. core-ci voted on patch set 8 V +1 11/18/26, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114858

  18. Benjamin Kott uploaded patch set 9 V +1 11/18/26, 22:17

  19. core-ci voted on patch set 9 V +1 11/18/26, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114937

  20. Benni Mack voted on patch set 9 CR +1 V +1 11/19/26, 06:56

  21. Benjamin Kott voted on patch set 9 CR +2 V +2 11/19/26, 08:25

  22. Benjamin Kott merged patch set 10 11/19/26, 08:25