Review main Merged

95430[TASK] Make the form editor null-safe

Benjamin Kott CR +2 V +2 Normal +91 −84 updated 11/19/26, 14:13

Commit message

Sixth step towards strictNullChecks. Only the backend extension is
left after this one.

The form editor barely touches the DOM directly, so almost none of its
errors were element lookups. They come from three other places.

Its modules keep their state in file-level singletons that a bootstrap
call assigns - the editor application, the configuration, the view
model, the stage element. Every module already exposes an accessor for
them, so the assumption that bootstrapping has happened is now stated
there once instead of at every read.

The application state stack hands out `undefined` for every key,
although each entry is seeded when a state is pushed. Reads state that
at the point they ask for it.

Most of the rest are optional properties of the editor configuration
that only the renderer selected for exactly that template ever reads:
the configuration options of an editor, its select options, its view
ports, the property collections of an element definition.

Several signatures were plainly wrong rather than optimistic and are
corrected instead. `createFormElement`, `buildPropertyPath`,
`renderAbstractStageArea`, `createAndAddAbstractViewFormElementToolbar`
and `addValidatorIdentifiersToFormElementProperty` all handle a missing
argument with `isUndefinedOrNull` in their first lines, yet declared
those parameters as required, and every caller had to pass `undefined`
into a type that did not admit it.

The non-null assertions this step relies on are added with
strictNullChecks itself, as no-unnecessary-type-assertion reports
every such assertion until the option is enabled.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 28

Show 8 more files

Review log 1322

  1. Benjamin Kott uploaded patch set 1 08/26/26, 13:09

  2. Benjamin Kott marked it work in progress 08/26/26, 13:24

  3. core-ci voted on patch set 1 V +1 08/26/26, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107143

  4. Benjamin Kott uploaded patch set 2 V +1 10/15/26, 16:16

  5. core-ci voted on patch set 2 V +1 10/15/26, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111232

  6. Benjamin Kott updated the commit message in patch set 3 V +1 10/15/26, 21:02

  7. core-ci voted on patch set 3 V +1 10/15/26, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111273

  8. Benjamin Kott rebased onto patch set 4 V +1 10/16/26, 07:45

  9. core-ci voted on patch set 4 V -1 10/16/26, 08:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111321

  10. Benjamin Kott rebased onto patch set 5 V -1 10/16/26, 09:26

  11. core-ci voted on patch set 5 V +1 10/16/26, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111336

  12. Benjamin Kott uploaded patch set 6 V +1 10/23/26, 14:49

  13. Benjamin Kott uploaded patch set 7 10/23/26, 15:42

  14. core-ci voted on patch set 6 V -1 10/23/26, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112328

  15. core-ci voted on patch set 7 V -1 10/23/26, 16:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112348

  16. Benjamin Kott uploaded patch set 8 V -1 11/18/26, 10:59

  17. core-ci voted on patch set 8 V +1 11/18/26, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114860

  18. Benjamin Kott uploaded patch set 9 V +1 11/19/26, 12:06

  19. core-ci voted on patch set 9 V +1 11/19/26, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115008

  20. Benni Mack voted on patch set 9 CR +1 V +1 11/19/26, 13:45

  21. Benjamin Kott voted on patch set 9 CR +2 V +2 11/19/26, 14:13

  22. Benjamin Kott merged patch set 10 11/19/26, 14:13