Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
95438[!!!][WIP][TASK] Remove legacy tree based site settings
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/38/95438/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/38/95438/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 1
Files 15
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+2 −1
- typo3/sysext/core/Classes/Settings/SettingsDiff.php+1 −32
- typo3/sysext/core/Classes/Site/Entity/Site.php+2 −4
- typo3/sysext/core/Classes/Site/Entity/SiteSettings.php+4 −28
- typo3/sysext/core/Classes/Site/SiteSettingsFactory.php+5 −4
- typo3/sysext/core/Classes/Site/SiteSettingsProvider.phpdeleted+0 −109
- typo3/sysext/core/Tests/Functional/Mail/TemplatedEmailFactoryTest.php+29 −52
- typo3/sysext/core/Tests/Functional/Site/Entity/SiteSettingsTest.php+19 −18
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/SysTemplateTreeBuilderTest.php+9 −5
- typo3/sysext/core/Tests/Functional/TypoScript/PageTsConfigFactoryTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Settings/SettingsDiffTest.php+1 −15
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_site_sets/Configuration/Sets/MultiSite/settings.definitions.yamlnew+5 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/MultiSiteTestPageAndSysTemplateImport.csv+4 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/MultiSiteTest.php+8 −2
- typo3/sysext/redirects/Tests/Functional/RedirectUpdate/SlugRedirectChangeItemFactoryTest.php+19 −24
Review log 612
-
Benjamin Franzke uploaded patch set 1 08/26/26, 17:30
-
core-ci voted on patch set 1 V -1 08/26/26, 17:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107156
-
Benjamin Franzke uploaded patch set 2
V -108/26/26, 19:01 -
Benjamin Franzke uploaded patch set 3 08/26/26, 19:10
-
core-ci voted on patch set 2 V -1 08/26/26, 19:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107157
-
core-ci voted on patch set 3 V -1 08/26/26, 19:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107158
-
Benjamin Franzke uploaded patch set 4
V -108/27/26, 06:23 -
core-ci voted on patch set 4 V -1 08/27/26, 06:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107213
-
Benjamin Franzke uploaded patch set 5
V -108/27/26, 07:18 -
core-ci voted on patch set 5 V +1 08/27/26, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107221
-
Benjamin Franzke uploaded patch set 6
V +108/27/26, 08:06 -
core-ci voted on patch set 6 V -1 08/27/26, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107224