Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Stale Breaking

95438[!!!][WIP][TASK] Remove legacy tree based site settings

Benjamin Franzke CR 0 V -1 Hard +111 −296 updated 08/27/26, 08:12

Commit message

Note: This is not intended for immediate merge,
but a first outlook, what is possible and what
should be adapted in regard of removing legacy
tree based site settings.

With #106894 site settings were stored as a map
instead of a settings tree

The custom `SiteSettingsProvider` is removed and
the default core `SettingsProvider` is used instead.

The custom `SiteSettingsProvider` was used to
implement support for the legacy anonymous tree
based settings. In constrast `SettingsProvider`
does only map a flat map of settings, allowing
to streamline setting handling to one definition
format: a flat map.

TODO:
 * Breaking.rst
 * Discuss if actually (already) desired to remove this
   * (maybe even backport or start with deprecations first?)
 * Have warnings for legacy settings that are being ignored?
 * Have a upgrade wizard that generates a settings map
   based on existing setting trees in config/sites/*/settings.yaml?
   (Does basically what the settings editor performs on save, consuming
   all setting values and writing a new derived representation)
 * Changes to `SettingsDiff` might be "too early", as they may
   still be needed for system settings later on

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 6
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/38/95438/6 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/38/95438/6 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 1

Files 15

Review log 612

  1. Benjamin Franzke uploaded patch set 1 08/26/26, 17:30

  2. core-ci voted on patch set 1 V -1 08/26/26, 17:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107156

  3. Benjamin Franzke uploaded patch set 2 V -1 08/26/26, 19:01

  4. Benjamin Franzke uploaded patch set 3 08/26/26, 19:10

  5. core-ci voted on patch set 2 V -1 08/26/26, 19:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107157

  6. core-ci voted on patch set 3 V -1 08/26/26, 19:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107158

  7. Benjamin Franzke uploaded patch set 4 V -1 08/27/26, 06:23

  8. core-ci voted on patch set 4 V -1 08/27/26, 06:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107213

  9. Benjamin Franzke uploaded patch set 5 V -1 08/27/26, 07:18

  10. core-ci voted on patch set 5 V +1 08/27/26, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107221

  11. Benjamin Franzke uploaded patch set 6 V +1 08/27/26, 08:06

  12. core-ci voted on patch set 6 V -1 08/27/26, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107224