Review main Abandoned

95440[BUGFIX] Skip unconvertible children in ObjectStorageConverter

Benjamin Kott CR +1 V +1 Normal +142 −0 updated 09/02/26, 14:27

Commit message

The property mapper converts a child it cannot resolve to null, but
still keeps it in the list of converted child properties.
ObjectStorageConverter passed those straight into
ObjectStorage->attach(), which raised an uncatchable TypeError,
since PropertyMapper->convert() only catches exceptions, and took
the whole request down with it.

Child properties that are no objects are now skipped and no longer
reach the storage. Besides null, this covers the scalars and arrays
an element type that is not a class converts to, which fail in the
same way. The report reached this through a multi value select
field submitted without a selection, which sends an empty string
for the item.

Review

  • Code review CR +1
    • Andreas Kienast +1
  • Verified V +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 913

  1. Benjamin Kott uploaded patch set 1 08/26/26, 22:30

  2. core-ci voted on patch set 1 V +1 08/26/26, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107194

  3. Georg Ringer voted on patch set 1 CR +1 V +1 08/27/26, 05:42

  4. Andreas Kienast commented on patch set 1 08/27/26, 06:40

    ObjectStorageConverter.php:46

    Should we be even more strict by guarding this with `!is_object($subProperty)`?
  5. Andreas Kienast uploaded patch set 2 CR +1 V +1 08/27/26, 06:52

  6. Andreas Kienast commented on patch set 2 08/27/26, 06:53

    ObjectStorageConverter.php:46 Reply

    Done
  7. Andreas Kienast uploaded patch set 3 08/27/26, 06:59

  8. core-ci voted on patch set 2 V +1 08/27/26, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107216

  9. Andreas Kienast uploaded patch set 4 08/27/26, 07:00

  10. Andreas Kienast voted on patch set 4 CR +1 V +1 08/27/26, 07:00

  11. core-ci voted on patch set 3 V +1 08/27/26, 07:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107217

  12. core-ci voted on patch set 4 V +1 08/27/26, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107218

  13. Georg Ringer abandoned the change 09/02/26, 14:27