Review main Merged

95441[BUGFIX] Read all properties of lazily loaded objects

Benjamin Kott CR +2 V +2 Normal +96 −0 updated 09/02/26, 09:07

Commit message

LazyLoadingProxy::__get() hands a property lookup to the domain
object API of the real instance, while __isset() looked the raw
property up on it. For the protected properties an entity normally
has, that answered false, so the Symfony property accessor behind
ObjectAccess concluded the property could not be read at all and
GenericObjectValidator refused to validate it.

__isset() now asks the real instance the same way __get() does, so
every property reachable through the proxy reports as set unless
its value is null.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1015

  1. Benjamin Kott uploaded patch set 1 08/26/26, 23:10

  2. core-ci voted on patch set 1 V +1 08/26/26, 23:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107195

  3. Benjamin Kott rebased onto patch set 2 V +1 09/02/26, 05:58

  4. core-ci voted on patch set 2 V -1 09/02/26, 06:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107561

  5. Benni Mack uploaded patch set 3 V -1 09/02/26, 06:45

  6. core-ci voted on patch set 3 V -1 09/02/26, 06:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107568

  7. Benni Mack commented on patch set 4 V -1 09/02/26, 07:00

    Published edit on patch set 3.
  8. Oliver Klee voted on patch set 4 V +1 09/02/26, 07:04

  9. Benni Mack voted on patch set 4 CR +1 V +1 09/02/26, 07:09

  10. core-ci voted on patch set 4 V -1 09/02/26, 07:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107574

  11. Benni Mack uploaded patch set 5 CR +1 V +1 09/02/26, 08:05

  12. core-ci voted on patch set 5 V +1 09/02/26, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107581

  13. Stefan Bürk voted on patch set 5 CR +1 V +1 09/02/26, 09:04

  14. Benni Mack voted on patch set 5 CR +2 V +2 09/02/26, 09:07

  15. Benni Mack merged patch set 6 09/02/26, 09:07