Review main Merged

95442[BUGFIX] Ignore enable fields in Extbase overlays

Benjamin Kott CR +2 V +2 Normal +223 −6 updated 09/02/26, 09:00

Commit message

The Extbase query setting setIgnoreEnableFields() switched off the
enable fields for the records a query selects, but not for the
translations those records are overlaid with. PageRepository fetches the
overlay with a FrontendRestrictionContainer built from the visibility
aspect of the context it was given, and Extbase never told that context
about the query settings. A hidden translation was therefore never
found: with languageOverlayMode hideNonTranslated the record was dropped
from the result while count() still counted it, and with the default
overlay mode the untranslated default language record was returned
instead.

Extbase now mirrors ignoreEnableFields and enableFieldsToBeIgnored into
the visibility aspect of the cloned context the overlay is done with, so
hidden and time-restricted translations are found as well. Frontend user
group restrictions are not part of that aspect and stay applied to
translations.

An existing test documented the previous behaviour as buggy and is
corrected along with it.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 810

  1. Benjamin Kott uploaded patch set 1 08/26/26, 23:36

  2. Benjamin Kott commented on patch set 1 CR -1 08/26/26, 23:42

    needs moving important file
  3. core-ci voted on patch set 1 V +1 08/26/26, 23:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107196

  4. Andreas Kienast commented on patch set 1 08/27/26, 07:04

    Typo3DbBackend.php:222

    AFAICS this relies on hard-coded field names and ignores the fact the field names are configurable in TCA. Please use the Schema API to resolve the correct field names.
  5. Andreas Kienast commented on patch set 1 08/27/26, 07:10

    Typo3DbBackend.php:222 Reply

    I had a wrong assumption. Those are the keys of `ctrl/enablecolumns`, not literal field names. Sorry for the noise.
  6. Andreas Kienast uploaded patch set 2 CR -1 V +1 08/27/26, 07:12

  7. core-ci voted on patch set 2 V +1 08/27/26, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107220

  8. Benni Mack voted on patch set 2 CR +1 V +1 09/01/26, 11:39

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 09/01/26, 20:58

  10. Stefan Bürk merged patch set 3 09/02/26, 09:00