95446[TASK] Cover file collection sorting with an enum
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/15.0/Important-110540-FileCollectorSortingUsesAnEnum.rstnew+48 −0
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php+4 −1
- typo3/sysext/frontend/Classes/DataProcessing/FilesProcessor.php+7 −4
- typo3/sysext/frontend/Classes/Resource/FileCollectionSorting.phpnew+45 −0
- typo3/sysext/frontend/Classes/Resource/FileCollector.php4+4 −12
Review log 911
-
Elias Häußler uploaded patch set 1 08/27/26, 07:48
-
Mathias Brodala commented on patch set 1 CR -1 08/27/26, 07:54
-
core-ci voted on patch set 1 V +1 08/27/26, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107223
-
Elias Häußler commented on patch set 1 08/27/26, 07:57
FileCollector.php:191ReplyEven if the class is marked as `@internal`? -
Mathias Brodala commented on patch set 1 CR 0 08/27/26, 07:59
FileCollector.php:191ReplyYou are right, in this case the change is acceptable. Still I'd vote for an Important RST to raise a notice for people directly using this. -
Georg Ringer voted on patch set 1 CR +1 V +1 09/02/26, 09:26
-
Georg Ringer uploaded patch set 2
CR +1V +109/02/26, 11:53 -
Georg Ringer voted on patch set 2 CR +1 V +1 09/02/26, 11:53
-
core-ci voted on patch set 2 V +1 09/02/26, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107618
-
Benni Mack commented on patch set 2 CR +2 V +2 09/02/26, 12:04
FileCollector.php:191ReplyDone -
Benni Mack merged patch set 3 09/02/26, 12:05
FileCollector.php:191