Review main Merged

95458[BUGFIX] Make Extbase QueryResult serializable again

Georg Ringer CR +2 V +2 Normal +216 −2 updated 09/01/26, 20:01

Commit message

Caching an Extbase QueryResult failed with "Serialization of
'Closure' is not allowed". Typo3QuerySettings is the only class
in the chain without __sleep(), so its injected
ConfigurationManager pulled the whole compiled DI container into
the payload.

Typo3QuerySettings now serializes its own state only and restores
the injected services on wake-up.

Two follow-up defects in the wake-up path are fixed as well:
Query::__wakeup() resolved DataMapFactory through makeInstance(),
which cannot build a non-public service with constructor
arguments, and it never restored the container that execute()
needs. QueryResult::__wakeup() did not hand the query back to the
data mapper, which needs it to determine the language aspect and
the parent query of relations.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 89

  1. Georg Ringer uploaded patch set 1 08/27/26, 20:06

  2. Georg Ringer commented on patch set 1 08/27/26, 20:06

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 08/27/26, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107290

  4. Wouter Wolters voted on patch set 1 CR +1 08/27/26, 20:35

  5. Benni Mack voted on patch set 1 CR +1 09/01/26, 17:08

  6. Benni Mack voted on patch set 1 V +1 09/01/26, 19:11

  7. Oliver Klee voted on patch set 1 V +1 09/01/26, 19:12

  8. Stefan Bürk voted on patch set 1 CR +2 V +2 09/01/26, 19:18

  9. Stefan Bürk merged patch set 2 09/01/26, 20:01