Review main Merged

95470[BUGFIX] Restrict allowed characters of pages cache tags

Georg Ringer CR +2 V +2 Easy +2 −0 updated 09/01/26, 12:19

Commit message

The field `pages.cache_tags` accepted arbitrary input, while the
caching framework only allows `[a-zA-Z0-9_%-&]` per tag. A single
tag containing e.g. a space made `VariableFrontend::set()` throw an
`InvalidArgumentException`, which broke the frontend of that page
on the next cache write.

The field is now evaluated with `trim,is_in`, so invalid characters
are stripped in FormEngine as well as in DataHandler. Writing a
list as "News, Blog" keeps working, since the stored value is
exploded and trimmed per tag.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Georg Ringer uploaded patch set 1 08/28/26, 08:55

  2. Georg Ringer commented on patch set 1 08/28/26, 08:55

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 08/28/26, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107321

  4. Matthias Vogel voted on patch set 1 CR +1 V +1 08/28/26, 09:43

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 09/01/26, 12:01

  6. Oliver Klee voted on patch set 1 CR +1 09/01/26, 12:03

  7. Stefan Bürk merged patch set 2 09/01/26, 12:19