Review main Merged

95474[BUGFIX] Filter moved workspace records by language

Benjamin Kott CR +2 V +2 Normal +72 −6 updated 09/10/26, 08:07

Commit message

WorkspaceService collects the changes of a workspace from three queries:
the versioned records, the new records and the records that were moved.
The first two restrict their result to the requested language, the third
one never did.

The workspaces module therefore kept listing a moved element under every
language filter, and publishing a single language published moved
records of all languages along with it.

The language constraint is now applied to the moved records as well, and
a table that is not language aware contributes nothing when a
translation is requested, the way the other two queries already behave.

The three language checks in this class used
MathUtility::canBeInterpretedAsInteger() on an argument that is typed
?int, where a null comparison says the same thing; they are simplified
along the way.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1012

  1. Benjamin Kott uploaded patch set 1 08/28/26, 09:26

  2. Benjamin Kott wrote 08/28/26, 14:16

    Unset private
  3. Benjamin Kott rebased onto patch set 2 08/31/26, 08:35

  4. core-ci voted on patch set 2 V +1 08/31/26, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107391

  5. Benni Mack commented on patch set 2 09/02/26, 16:08

    WorkspaceService.php:595

    why should we use the MathUtility, but we could use !== null
  6. Benjamin Kott uploaded patch set 3 V +1 09/09/26, 08:30

  7. Benjamin Kott commented on patch set 3 09/09/26, 08:31

    WorkspaceService.php:595 Reply

    Done
  8. core-ci voted on patch set 3 V +1 09/09/26, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108150

  9. Benni Mack voted on patch set 3 CR +1 V +1 09/09/26, 08:46

  10. Georg Ringer voted on patch set 3 CR +1 V +1 09/09/26, 14:21

  11. Benjamin Kott voted on patch set 3 CR +2 V +2 09/10/26, 07:54

  12. Benjamin Kott merged patch set 4 09/10/26, 08:07