95477[BUGFIX] Isolate Camino content element rendering
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/95477/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/95477/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/core/Documentation/Changelog/14.3/Important-109670-CaminoContentElementTypoScriptObjectRenamed.rstnew+48 −0
- typo3/sysext/theme_camino/Configuration/Sets/camino/TypoScript/content.typoscript+7 −3
- typo3/sysext/theme_camino/Tests/Functional/Fixtures/Extensions/camino_extbase_test/Classes/Controller/TestController.phpnew+31 −0
- typo3/sysext/theme_camino/Tests/Functional/Fixtures/Extensions/camino_extbase_test/Configuration/Services.yamlnew+8 −0
- typo3/sysext/theme_camino/Tests/Functional/Fixtures/Extensions/camino_extbase_test/composer.jsonnew+23 −0
- typo3/sysext/theme_camino/Tests/Functional/Fixtures/Extensions/camino_extbase_test/ext_localconf.phpnew+14 −0
- typo3/sysext/theme_camino/Tests/Functional/Fixtures/TypoScript/ContentRendering.typoscriptnew+10 −0
- typo3/sysext/theme_camino/Tests/Functional/Fixtures/TypoScript/ExtbasePlugin.typoscriptnew+10 −0
- typo3/sysext/theme_camino/Tests/Functional/Fixtures/content.csvnew+3 −0
- typo3/sysext/theme_camino/Tests/Functional/Fixtures/extbase-plugin.csvnew+3 −0
- typo3/sysext/theme_camino/Tests/Functional/Rendering/ContentRenderingTest.phpnew+68 −0
- typo3/sysext/theme_camino/Tests/Functional/Rendering/ExtbasePluginRenderingTest.phpnew+69 −0
Review log 1622
-
Radostin Milenov uploaded patch set 1 08/30/26, 16:16
-
core-ci voted on patch set 1 V -1 08/30/26, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107360
-
Radostin Milenov uploaded patch set 2
V -108/30/26, 16:45 -
core-ci voted on patch set 2 V -1 08/30/26, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107361
-
Radostin Milenov uploaded patch set 3
V -108/30/26, 17:05 -
core-ci voted on patch set 3 V +1 08/30/26, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107362
-
Simon Schaufelberger updated the commit message in patch set 4
V +108/30/26, 19:24 -
core-ci voted on patch set 4 V +1 08/30/26, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107363
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 08/30/26, 20:00
-
Markus Gerdes commented on patch set 4 CR +1 08/30/26, 20:58
Looks good to me -
Garvin Hicking commented on patch set 4 08/31/26, 05:10
Isn't this a breaking change for anyone that might have adapted/customized camino? Maybe adding an Importsnt changelog ReST would be needed? -
Radostin Milenov commented on patch set 4 08/31/26, 05:51
Reply
Legit concern. Will it be enough? -
Stefan Bürk commented on patch set 4 08/31/26, 07:09
Not tested, but does this not break usage of extbase plugins and theme_camino in case fluid_styled_content is not installed ? -
Radostin Milenov commented on patch set 4 08/31/26, 07:47
Reply
It shouldn't. But it's also a fair point. I'll look into it. -
Radostin Milenov commented on patch set 4 08/31/26, 07:49
@stefan@buerk.tech Good catch. It did break. I'll restore compatibility in the next patchset -
Radostin Milenov uploaded patch set 5
CR +1V +108/31/26, 08:24 -
core-ci voted on patch set 5 V -1 08/31/26, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107390
-
Radostin Milenov uploaded patch set 6
V -108/31/26, 09:22 -
core-ci voted on patch set 6 V +1 08/31/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107396
-
Radostin Milenov commented on patch set 6 09/05/26, 08:34
Reply
Done -
Simon Schaufelberger voted on patch set 6 CR +1 V +1 09/08/26, 15:23