Review main Ready for review Stale

95477[BUGFIX] Isolate Camino content element rendering

Radostin Milenov CR +1 V +1 Hard +294 −3 updated 09/08/26, 15:23

Commit message

Use a Camino-specific TypoScript object for content element
rendering. This prevents fluid_styled_content loaded afterwards from
replacing the Camino configuration.

Add a functional test covering the conflicting include order.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 6
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/95477/6 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/95477/6 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1622

  1. Radostin Milenov uploaded patch set 1 08/30/26, 16:16

  2. core-ci voted on patch set 1 V -1 08/30/26, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107360

  3. Radostin Milenov uploaded patch set 2 V -1 08/30/26, 16:45

  4. core-ci voted on patch set 2 V -1 08/30/26, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107361

  5. Radostin Milenov uploaded patch set 3 V -1 08/30/26, 17:05

  6. core-ci voted on patch set 3 V +1 08/30/26, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107362

  7. Simon Schaufelberger updated the commit message in patch set 4 V +1 08/30/26, 19:24

  8. core-ci voted on patch set 4 V +1 08/30/26, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107363

  9. Simon Schaufelberger voted on patch set 4 CR +1 V +1 08/30/26, 20:00

  10. Markus Gerdes commented on patch set 4 CR +1 08/30/26, 20:58

    Looks good to me
  11. Garvin Hicking commented on patch set 4 08/31/26, 05:10

    Isn't this a breaking change for anyone that might have adapted/customized camino? Maybe adding an Importsnt changelog ReST would be needed?
  12. Radostin Milenov commented on patch set 4 08/31/26, 05:51

    Reply

    Legit concern. Will it be enough?
  13. Stefan Bürk commented on patch set 4 08/31/26, 07:09

    Not tested, but does this not break usage of extbase plugins and theme_camino in case fluid_styled_content is not installed ?
  14. Radostin Milenov commented on patch set 4 08/31/26, 07:47

    Reply

    It shouldn't. But it's also a fair point. I'll look into it.
  15. Radostin Milenov commented on patch set 4 08/31/26, 07:49

    @stefan@buerk.tech Good catch. It did break. I'll restore compatibility in the next patchset
  16. Radostin Milenov uploaded patch set 5 CR +1 V +1 08/31/26, 08:24

  17. core-ci voted on patch set 5 V -1 08/31/26, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107390

  18. Radostin Milenov uploaded patch set 6 V -1 08/31/26, 09:22

  19. core-ci voted on patch set 6 V +1 08/31/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107396

  20. Radostin Milenov commented on patch set 6 08/31/26, 11:37

    Reply

    Done

    Reply

    Done
  21. Radostin Milenov commented on patch set 6 09/05/26, 08:34

    Reply

    Done
  22. Simon Schaufelberger voted on patch set 6 CR +1 V +1 09/08/26, 15:23