95478[TASK] Update PHPStan to v2.2.10
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1114
-
Elias Häußler uploaded patch set 1 08/31/26, 05:20
-
Elias Häußler commented on patch set 1 08/31/26, 05:24
This *could* be fixed in main and 14.3 as well. PHPStan did not report an error there, because `treatPhpDocTypesAsCertain: false` is set. Should we therefore keep it as-is (v13 only) or apply this to all branches? -
core-ci voted on patch set 1 V -1 08/31/26, 05:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107377
-
Elias Häußler uploaded patch set 2
V -108/31/26, 05:34 -
core-ci voted on patch set 2 V +1 08/31/26, 05:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107378
-
Garvin Hicking commented on patch set 2 08/31/26, 06:46
Reply
regarding thread https://typo3.slack.com/archives/C03AM9R17/p1788146254192939 I would prefer to keep the PHPStan update consistent and also bump the dependency for main+v14, yes. Baseline entry is good for me, thanks! 😊 -
Oliver Klee voted on patch set 2 CR +1 V +1 08/31/26, 08:17
-
Stefan Bürk commented on patch set 2 CR -1 08/31/26, 08:45
On it ... -
Stefan Bürk rebased onto patch set 3
CR +1V +108/31/26, 09:24 -
Stefan Bürk commented on patch set 3 08/31/26, 09:26
Reply
Same feeling - pushed the upports for main and 14.3, adjusted the commit message and forge issue.Reply
Done -
core-ci voted on patch set 3 V +1 08/31/26, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107399
-
Stefan Bürk voted on patch set 3 CR +2 V +2 08/31/26, 09:41
-
Garvin Hicking voted on patch set 3 CR +1 V +1 08/31/26, 09:41
-
Stefan Bürk merged patch set 4 08/31/26, 09:41