Review 13.4 Merged

95480[BUGFIX] Allow database names containing a dot in schema migration

Stefan Bürk CR +2 V +2 Easy +9 −3 updated 08/31/26, 07:52

Commit message

The database analyzer / compare tool aborts with a misleading
"TableAlreadyExists" exception when the configured database name
contains a dot, e.g. "db.dot" or "a.b.c":

  The table with name "db.dot" already exists.

ConnectionMigrator::buildExpectedSchemaDefinitions() set the raw
database name as the default namespace of the expected schema. Doctrine
DBAL then prepends that namespace to every table name and parses the
result as a qualified "<namespace>.<name>" identifier, splitting it at
the dot. As a consequence every table collapses to the very same key
(the database name) and adding the second table fails.

The introspected ("from") schema is not affected because Doctrine uses
the current schema name as default namespace, which is null for
platforms without schema support (MySQL, MariaDB, SQLite).

The expected schema now derives its default namespace the same way, so
both schemas stay comparable and dotted database names no longer break
the schema migration. The defaultTableOptions handling is left
untouched on purpose.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 08/31/26, 07:28

    Cherry Picked from branch 14.3.
  2. core-ci voted on patch set 1 V +1 08/31/26, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107381

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 08/31/26, 07:52

  4. Stefan Bürk merged patch set 2 08/31/26, 07:52