95482[BUGFIX] Always exclude app package from active packages
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Benjamin Franzke +1
- Benjamin Kott +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Helmut Hummel +2
- Benjamin Franzke +1
- Benjamin Kott +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Package/PackageManager.php3+6 −4
- typo3/sysext/core/Classes/Package/PackageSetup.php3+4 −0
- typo3/sysext/core/Tests/Unit/Package/PackageSetupTest.php2new+70 −0
- typo3/sysext/install/Classes/Service/SetupService.php3+3 −2
- typo3/sysext/install/Tests/Functional/Service/SetupServiceTest.php2+42 −0
Review log 2832
Show 67 earlier messages
-
Helmut Hummel uploaded patch set 1 08/31/26, 07:42
-
Helmut Hummel marked it work in progress 08/31/26, 07:44
-
Mathias Brodala commented on patch set 1 08/31/26, 07:46
-
core-ci voted on patch set 1 V +1 08/31/26, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107384
-
Helmut Hummel commented on patch set 1 09/02/26, 08:36
PackageManager.php:717ReplyNo. It removes the evaluation of things like Configuration/TCA, when the root is an extension anyway, which lead to evaluating those resources twice -
Mathias Brodala commented on patch set 1 09/02/26, 08:37
PackageManager.php:717ReplyAh, now that makes a lot more sense, thanks for clarification! -
Benjamin Kott commented on patch set 1 09/02/26, 14:09
This change is ready for review.the patch seems to resolve by reading, still it misses any tests to validate the behavior
-
Benjamin Kott marked it work in progress 09/02/26, 14:09
-
Benjamin Franzke commented on patch set 1 09/07/26, 11:31
SetupService.php:412Thanks, I like that this change removes the bool flag from `getActivePackages()` 👍 I would suggest to use `isPackageActive()` instead of guarding via the type qualifier, since that makes the code cleaner and more robust. Ihe intent to avoid double registration becomes more easier to understand based on the code alone, and we do not rely on the `type` alone, which may technically even be different) ```suggestion if (!$this->packageManager->isPackageActive(InstalledVersions::getRootPackage()['name'])) { ``` -
Helmut Hummel commented on patch set 1 09/09/26, 12:26
SetupService.php:412Reply> since that makes the code cleaner and more robust. Not sure, because all packages defining anything in extra.typo3/cms are considered active typo3 extensions since TYPO3 v11 https://github.com/TYPO3/typo3/blob/16596e3927d4bf9fafbac89befb27475f6727ed1/typo3/sysext/core/Classes/Composer/PackageArtifactBuilder.php#L41 I'd rather make the intent even more clear, since exposing configuration resource for the VirtualAppPackage was never intended and also does not happen for extension:setup command, but only during setup command or web based setup. The intention was only to publish potentially defined public resources of the VirtualAppPackage (project package) during (initial) setup. So the fix would be to pour that in code instead. I will change this accordingly -
Helmut Hummel uploaded patch set 2
V +109/09/26, 13:07 -
core-ci voted on patch set 2 V -1 09/09/26, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108181
-
Helmut Hummel uploaded patch set 3
V -109/09/26, 13:21 -
Helmut Hummel marked it ready for review 09/09/26, 13:21
-
Helmut Hummel commented on patch set 3 09/09/26, 13:21
SetupService.php:412ReplyAcknowledged -
Helmut Hummel commented on patch set 3 09/09/26, 13:22
Reply
Done -
core-ci voted on patch set 3 V +1 09/09/26, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108183
-
Benjamin Franzke voted on patch set 3 CR +1 V +1 09/09/26, 13:41
-
Benjamin Kott commented on patch set 3 09/09/26, 14:15
PackageSetup.php:54is it intentional that the possible error messages are discarded here and not exposed? $messages = $this->resourcePublisher ->publishResources($this->packageManager ->getPackage(VirtualAppPackage::APP_PACKAGE_KEY)) ->getAllMessages(ContextualFeedbackSeverity::ERROR); -
Oliver Klee voted on patch set 3 V +1 09/09/26, 15:10
-
Helmut Hummel commented on patch set 3 09/09/26, 15:18
PackageSetup.php:54ReplyNo single message is exposed during the setup, especially because all actions are distributed in event listeners. for (error) messages individual commands can be used. in this case assets:publish -
Benjamin Kott voted on patch set 3 CR +1 V +1 09/09/26, 18:39
-
Benjamin Kott commented on patch set 3 09/09/26, 18:39
PackageSetup.php:54Replythx fine for me -
Simon Schaufelberger updated the commit message in patch set 4
CR +1V +109/09/26, 22:31 -
Simon Schaufelberger commented on patch set 4 09/09/26, 22:34
PackageSetupTest.php:68no assertions? Should the test than also use the specific attribute (don't know the name currently)SetupServiceTest.php:60no assertions? -
core-ci voted on patch set 4 V +1 09/09/26, 22:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108221
-
Helmut Hummel commented on patch set 4 09/10/26, 07:40
xPackageSetupTest.php:68Replythe assertions are in the expected method callsSetupServiceTest.php:60Replythe assertions are in the to be expected method calls -
Benjamin Franzke voted on patch set 4 CR +1 V +1 09/10/26, 07:42
-
Benjamin Kott voted on patch set 4 CR +1 V +1 09/10/26, 07:56
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 09/10/26, 07:58
-
Helmut Hummel commented on patch set 4 CR +2 V +2 09/10/26, 12:13
Thanks! -
Helmut Hummel merged patch set 5 09/10/26, 12:13
PackageManager.php:717