Review main Merged

95494[TASK] Add tests for plugin Startingpoint override

Stefan Bürk CR +2 V +2 Hard +514 −0 updated 09/01/26, 20:21

Commit message

The "Startingpoint" (tt_content fields "pages" and "recursive")
of an Extbase plugin content element overrides the TypoScript
setting persistence.storagePid of the plugin. This depends on
the raw record row reaching the rendering chain unfiltered and
silently broke for record based rendering (PAGEVIEW) in
v13.3.0 - v13.4.0, resolved as a side effect of #105518
without any test guarding the behaviour end to end.

Add functional coverage using frontend sub requests over the
rendering chains - FLUIDTEMPLATE with styles.content.get,
PAGEVIEW with f:render.contentArea and PAGEVIEW with the
documented f:cObject record pattern - asserting both black box
(record identifiers a repository of a fixture plugin returned,
against a decoy storagePid) and white box (probe plugins
rendering the effective persistence.storagePid of the framework
configuration and of the query settings), each with and without
a Startingpoint being set.

Restoring the pre #105518 behaviour turns the PAGEVIEW variants
red while the FLUIDTEMPLATE variants stay green, guarding the
historic regression vector.

The v13.4 backport omits the f:render.contentArea variants,
since that ViewHelper and the ContentArea object were added in
v14.2, and covers record rendering through f:cObject, which is
the only v13.4 way to render them. It further requires an
explicit PLUGIN_TYPE_CONTENT_ELEMENT for the probe plugins, the
page-content data processor in the PAGEVIEW setup and the
annotation based Validate attribute.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 19

Review log 912

  1. Stefan Bürk uploaded patch set 1 08/31/26, 16:02

  2. core-ci voted on patch set 1 V +1 08/31/26, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107434

  3. Oliver Klee voted on patch set 1 V +1 08/31/26, 16:48

  4. Stefan Bürk uploaded patch set 2 V +1 09/01/26, 11:41

  5. core-ci voted on patch set 2 V +1 09/01/26, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107482

  6. Oliver Klee voted on patch set 2 V +1 09/01/26, 11:50

  7. Stefan Bürk uploaded patch set 3 V +1 09/01/26, 12:32

  8. core-ci voted on patch set 3 V +1 09/01/26, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107487

  9. Benni Mack voted on patch set 3 CR +1 V +1 09/01/26, 15:09

  10. Georg Ringer voted on patch set 3 CR +1 V +1 09/01/26, 20:19

  11. Stefan Bürk voted on patch set 3 CR +2 V +2 09/01/26, 20:21

  12. Stefan Bürk merged patch set 4 09/01/26, 20:21