Review 14.3 Merged

95497[BUGFIX] Handle backend logo as system resource

Benni Mack CR +2 V +2 Normal +229 −21 updated 08/31/26, 22:11

Commit message

The backend logo configured as "backendLogo" extension configuration
of EXT:backend was evaluated twice: through the system resource API
for the URL, and through GeneralUtility::getFileAbsFileName() for the
file existence check and the image dimensions.

The latter triggers an E_USER_DEPRECATED for "PKG:" identifiers, so
the resource identifier syntax recommended since v14 is penalized in
the one place its siblings loginLogo, loginBackgroundImage and
backendFavicon accept it silently.

The logo is now resolved through the system resource API only.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 46

  1. Benni Mack commented on patch set 1 08/31/26, 20:48

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 08/31/26, 20:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107438

  3. Benni Mack commented on patch set 2 V -1 08/31/26, 21:04

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 08/31/26, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107439

  5. Benni Mack voted on patch set 2 CR +2 V +2 08/31/26, 22:11

  6. Benni Mack merged patch set 3 08/31/26, 22:11