Review main Merged

95502[TASK] Create error handlers directly in Bootstrap

Benni Mack CR +2 V +2 Easy +14 −18 updated 09/01/26, 07:14

Commit message

Bootstrap registered its early LogManager as a singleton instance in
GeneralUtility, so the error and the exception handler could pick it
up through makeInstance(), and removed it again once the container
was up. Both handlers are created by Bootstrap itself, so the
LogManager is handed to initializeErrorHandling() and assigned to
the handlers directly now, which makes that pair of calls obsolete.

Both handlers are created with "new" for that reason. Registering
the exception handler is done in its constructor and the instance is
never looked up again, so AbstractExceptionHandler does not need to
implement SingletonInterface either.

Since the handlers do not go through GeneralUtility anymore, they
are no longer subject to XCLASSing via $TYPO3_CONF_VARS[SYS][Objects]
and to legacy class alias resolution. Both are configured with a
class name in $TYPO3_CONF_VARS[SYS] already, which is the intended
way to exchange them.

createPackageManager() creates its DependencyOrderingService with
"new" as well. The service is stateless, and this runs long before
the container exists.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Benni Mack uploaded patch set 1 08/31/26, 22:03

  2. core-ci voted on patch set 1 V +1 08/31/26, 22:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107448

  3. Helmut Hummel voted on patch set 1 CR +1 V +1 09/01/26, 05:14

  4. Benni Mack marked it ready for review 09/01/26, 06:32

  5. Benjamin Franzke voted on patch set 1 CR +1 09/01/26, 06:51

  6. Benjamin Franzke voted on patch set 1 CR +2 V +2 09/01/26, 07:14

  7. Benjamin Franzke merged patch set 2 09/01/26, 07:14