Review main Abandoned

95520[BUGFIX] Resolve static routes befor language handling

Dennis Purisevic CR -2 V 0 Easy +1 −5 updated 10/02/26, 12:31

Commit message

Previously, if a site had a static route robots.txt and two languages, de and en, with the bases /de and /en, then calling https://domain.org/robots.txt returned a 404 because the URL matched no language. Calling https://domain.org/de/robots.txt also returned a 404, since no static route named /de/robots.txt exists.

Resolving static routes first solves this. If a user does need the language key in the URL, they can simply include it in the static route name.

Review

  • Code review CR -2
    • Benni Mack -2
  • Verified V 0
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Dennis Purisevic uploaded patch set 1 09/01/26, 12:45

  2. core-ci voted on patch set 1 V +1 09/01/26, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107490

  3. Benni Mack commented on patch set 1 CR -2 09/01/26, 13:01

    this is a breaking change unfortunately, and it's been an ongoing discussion, which goes first. In the short-term, I suggest to reorder the middlewares in your project to achieve your needs
  4. Garvin Hicking abandoned the change 10/02/26, 12:31

    closing, see bennis feedback