95521[!!!][TASK] Drop SingletonInterface from DI-only Extbase classes
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Wouter Wolters +1
-
Verified V +2 Done
- Stefan Bürk +2
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-110578-SingletonInterfaceRemovedFromCoreServices.rst+9 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/QueryObjectModelFactory.php+18 −18
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractTypeConverter.php+1 −2
- typo3/sysext/extbase/Classes/Service/ExtensionService.php+20 −20
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php2+7 −1
- typo3/sysext/extbase/Tests/Functional/Service/Fixtures/tt_content_with_plugin_in_two_languages.csvnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Service/ExtensionServiceTest.php+30 −8
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+4 −4
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php2+9 −0
- typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php+5 −2
Review log 911
-
Benni Mack uploaded patch set 1 09/01/26, 13:26
-
core-ci voted on patch set 1 V +1 09/01/26, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107492
-
Stefan Bürk voted on patch set 1 CR +1 V +1 09/01/26, 19:22
-
Wouter Wolters commented on patch set 1 09/01/26, 19:31
UploadedFileReferenceConverter.php:53same here, why not include it in the PHPdoc above? -
Benni Mack commented on patch set 2
CR +1V +109/01/26, 19:33Published edit on patch set 1. -
Benni Mack commented on patch set 2 09/01/26, 19:34
ValidatorResolver.php:40Replyits related to the Attribute, not the class, but I adapted it.UploadedFileReferenceConverter.php:53Replyits related to the Attribute, not the class, but I adapted it. -
Stefan Bürk voted on patch set 2 CR +1 V +1 09/01/26, 19:35
-
Wouter Wolters voted on patch set 2 CR +1 V +1 09/01/26, 19:40
-
core-ci voted on patch set 2 V +1 09/01/26, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107512
-
Stefan Bürk voted on patch set 2 CR +2 V +2 09/01/26, 19:48
-
Stefan Bürk merged patch set 3 09/01/26, 19:48
ValidatorResolver.php:40