Review 13.4 Merged

95531[BUGFIX] Skip inaccessible file references in FileCollector

Georg Ringer CR +2 V +2 Easy +9 −8 updated 09/01/26, 20:18

Commit message

FileCollector::addFileReferences() handed each uid to
ResourceFactory::getFileReferenceObject(), which throws when the
sys_file_reference record cannot be fetched. In the frontend the record
is looked up through PageRepository::checkRecord(), so a hidden
reference yields no data and the exception took down the whole page
render for every visitor.

Hidden references are inaccessible to the frontend by design, so they
are skipped now, just like the relation based lookup in the same class
already skips references whose file has gone missing.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 610

  1. Georg Ringer uploaded patch set 1 09/01/26, 19:50

  2. Georg Ringer commented on patch set 1 09/01/26, 19:50

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 09/01/26, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107519

  4. Stefan Bürk uploaded patch set 2 V -1 09/01/26, 20:06

  5. core-ci voted on patch set 1 V -1 09/01/26, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107519

  6. Georg Ringer rebased onto patch set 3 09/01/26, 20:08

  7. core-ci voted on patch set 2 V +1 09/01/26, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107523

  8. core-ci voted on patch set 3 V +1 09/01/26, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107524

  9. Georg Ringer voted on patch set 3 CR +2 V +2 09/01/26, 20:18

  10. Georg Ringer merged patch set 4 09/01/26, 20:18