Review main Merged

95538[BUGFIX] Render custom columns in the workspaces module

Benni Mack CR +2 V +2 Hard +263 −4 updated 09/02/26, 16:16

Commit message

Listeners of AfterDataGeneratedForWorkspaceEvent can enrich the
records shown in the workspaces module, but the record table
rendered a fixed set of columns and discarded any additional
data. Adding custom columns, which was possible until v7, thus
had no effect.

The record table now renders columns that listeners declare by
adding an "additional" section to a record. The columns are
determined from all records of the workspace instead of only
those of the current page, so the table header stays stable
while paging. The column count of the page separator row is
calculated as well now, instead of being hard coded to eight.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 78

  1. Benni Mack uploaded patch set 1 09/01/26, 21:17

  2. Benni Mack marked it work in progress 09/01/26, 21:18

  3. core-ci voted on patch set 1 V +1 09/01/26, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107536

  4. Benni Mack marked it ready for review 09/02/26, 08:13

  5. Georg Ringer voted on patch set 1 CR +1 V +1 09/02/26, 12:27

  6. Jochen Roth voted on patch set 1 CR +1 V +1 09/02/26, 15:40

  7. Benni Mack voted on patch set 1 CR +2 V +2 09/02/26, 16:16

  8. Benni Mack merged patch set 2 09/02/26, 16:16