Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review Stale

95539[BUGFIX] Respect content_from_pid for recursive CONTENT

Stefan Bürk CR 0 V 0 Normal +113 −1 updated 09/01/26, 22:40

Commit message

ContentObjectRenderer resolved the "this" keyword of the
"pidInList" property in two places with different values: the
recursive expansion in getQuery() used the current page id,
while getQueryConstraints() uses the content pid, which is the
target of the page property "Show content from page".

On a page using that property a CONTENT object with
"pidInList = this" therefore fetched records from the
configured page without "recursive", but silently fell back to
the current page and its subtree as soon as "recursive" was
set, since the expansion already wrote a concrete page id list
and the constraint never saw the keyword.

Resolve the keyword from the content pid in the recursive
expansion as well, making both places consistent.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/39/95539/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/39/95539/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 4

Review log 58

  1. Stefan Bürk uploaded patch set 1 09/01/26, 21:31

  2. Stefan Bürk uploaded patch set 2 09/01/26, 21:35

  3. core-ci voted on patch set 1 V +1 09/01/26, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107538

  4. core-ci voted on patch set 2 V +1 09/01/26, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107539

  5. Georg Ringer commented on patch set 2 09/01/26, 22:13

    not sure if we should backport that to 13.4, even if it makes things right it might change behaviour of installations without knowing
  6. Stefan Bürk commented on patch set 2 09/01/26, 22:31

    Reply

    ok. going to change that.
  7. Stefan Bürk uploaded patch set 3 V +1 09/01/26, 22:32

  8. core-ci voted on patch set 3 V +1 09/01/26, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107541