Review main Merged

95546[BUGFIX] Resolve record history authors by user type

Benni Mack CR +2 V +2 Normal +189 −12 updated 09/02/26, 10:56

Commit message

The history module and the workspaces record panel resolved the author
of a history entry against be_users without looking at the usertype
column of sys_history.

Since #107289 the Extbase history tracker writes entries with usertype
"FE" and a frontend user uid, so a change made by frontend user 3 was
displayed under the name of backend user 3. In the workspaces panel it
also rendered that backend user's avatar, and for an entry whose
backend user no longer exists Avatar->render() even fell back to the
avatar of the user currently logged in.

ElementInformationController and the recycler already check for "BE"
before resolving, the two places above now do so as well. A frontend
change is labelled as such, an entry without user information keeps
the existing "automated process" label.

Resolving frontend user names is left out on purpose: a backend user
may have no access to the fe_users record in question.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 56

  1. Benni Mack uploaded patch set 1 09/02/26, 06:58

  2. core-ci voted on patch set 1 V +1 09/02/26, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107573

  3. Georg Ringer voted on patch set 1 CR +1 V +1 09/02/26, 07:27

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 09/02/26, 10:52

  5. Benni Mack voted on patch set 1 CR +2 V +2 09/02/26, 10:56

  6. Benni Mack merged patch set 2 09/02/26, 10:56