Review main Merged

95559[TASK] Fix CGL violation in indexed_search test

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 09/02/26, 11:17

Commit message

The coding guidelines suite failed on main: the request
object in NonPublicStorageIndexingTest wrapped the
constructor call in parentheses before chaining, while the
rule set expects the plain form used everywhere else.

The commit hook and the "cglGit" suite only inspect the
files of the latest commit, so this was not rejected when
it was introduced.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 09/02/26, 10:57

  2. Oliver Klee voted on patch set 1 CR +1 V +1 09/02/26, 11:03

  3. core-ci voted on patch set 1 V +1 09/02/26, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107605

  4. Stefan Bürk commented on patch set 1 CR +2 V +2 09/02/26, 11:17

    Merging this now as de-facto no-brainer **and** test related only.
  5. Stefan Bürk merged patch set 2 09/02/26, 11:17