Review 14.3 Merged

95562[BUGFIX] Correlate workspace stage change and publish history

Benni Mack CR +2 V +2 Normal +130 −3 updated 09/02/26, 13:23

Commit message

The workspaces hook writes its history entries outside of
DataHandler->updateDB(), so it has to hand over the correlation id of
the current run itself. It did not, neither for the stage change in
version_setStage() nor for the two publish entries in version_swap()
and publishNewRecord().

RecordHistoryStore then fell back to a correlation id built only from
the table name and the uid, without the scope of the operation. Two
things followed from that. Stage changes and publishes could not be
correlated with the operation that caused them, so publishing forty
records wrote forty rows that no longer belonged together. And since
that fallback is derived from the record alone, it stayed the same for
the whole lifetime of a record, which made findEventsForCorrelation()
return every stage change and every publish of that record at once.

Hand the correlation id of the data handler over to all three calls.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benni Mack commented on patch set 1 09/02/26, 13:07

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/02/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107624

  3. Benni Mack voted on patch set 1 CR +2 V +2 09/02/26, 13:23

  4. Benni Mack merged patch set 2 09/02/26, 13:23