Review 14.3 Merged

95564[TASK] Add autocomplete to setup and language commands

Georg Ringer CR +2 V +2 Normal +49 −5 updated 09/02/26, 13:49

Commit message

Add value completion to the following command inputs:

- setup: options --driver, --distribution and --server-type
- language:update: argument locales

The suggestions are read from the container which has already been
booted by CommandApplication, the closures must not boot again.

--driver now only offers the connection types which are usable with
the database extensions of the current PHP installation. The
interactive "Database driver?" question is limited the same way, as
it offered values its own validator rejects.

--distribution only suggests inactive distributions, because active
ones can not be activated during setup, and suggests nothing if
typo3/cms-impexp is not available.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Georg Ringer uploaded patch set 1 09/02/26, 13:14

  2. Georg Ringer commented on patch set 1 09/02/26, 13:14

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/02/26, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107627

  4. Georg Ringer voted on patch set 1 CR +2 V +2 09/02/26, 13:49

  5. Georg Ringer merged patch set 2 09/02/26, 13:49