Review 14.3 Merged

95576[BUGFIX] Do not migrate unrelated history entries on publish

Georg Ringer CR +2 V +2 Normal +60 −3 updated 09/02/26, 18:26

Commit message

When a workspace version is published, publishRecord() repoints the
history entries of the versioned record to the live record. A record
that was created in a workspace keeps its uid when it is published, so
publishNewRecord() passes a versioned uid of 0, and the migration then
matched every entry of that table whose recuid is 0 and bound them to
the published record.

Skip the migration when there is no versioned record to migrate from.

The update was also not restricted to the workspace being published,
so entries of the live record and of versions in other workspaces
could be repointed as well. Restrict it accordingly.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 46

  1. Georg Ringer commented on patch set 1 09/02/26, 18:10

    Cherry Picked from branch main.
  2. Stefan Bürk uploaded patch set 2 09/02/26, 18:16

  3. core-ci voted on patch set 1 V +1 09/02/26, 18:19 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107669

  4. core-ci voted on patch set 2 V +1 09/02/26, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107670

  5. Stefan Bürk voted on patch set 2 CR +2 V +2 09/02/26, 18:26

  6. Stefan Bürk merged patch set 3 09/02/26, 18:26