Review main Merged

95586[BUGFIX] Keep unique values untouched in workspaces

Benni Mack CR +2 V +2 Normal +38 −29 updated 09/04/26, 09:17

Commit message

A record edited in a workspace is a versioned record. It lives on
the same pid as its live counterpart and starts out with exactly
the same values.

The uniqueness lookup behind the "eval" keywords "unique" and
"uniqueInPid" of type=input and type=email fields did not know
about that: it counted the live record as a collision of its own
version, so a counter was appended on every single save, even when
the editor never touched the field. Creating the version alone was
already enough, since insertNewCopyVersion() passes the complete
field array through checkValue().

The lookup now ignores the live counterpart of the record being
checked, just like SlugHelper::applyRecordConstraint() has always
done for type=slug fields.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 79

  1. Benni Mack uploaded patch set 1 09/02/26, 23:12

  2. Benni Mack updated the commit message in patch set 2 09/02/26, 23:13

  3. core-ci voted on patch set 1 V +1 09/02/26, 23:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107698

  4. core-ci voted on patch set 2 V +1 09/02/26, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107699

  5. Oliver Klee voted on patch set 2 V +1 09/03/26, 06:51

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 09/04/26, 08:28

  7. Jochen Roth voted on patch set 2 CR +1 V +1 09/04/26, 09:12

  8. Benni Mack voted on patch set 2 CR +2 V +2 09/04/26, 09:17

  9. Benni Mack merged patch set 3 09/04/26, 09:17