Review main Merged

95600[BUGFIX] Avoid breadcrumb warning on root page

Anton Danilov CR +2 V +2 Easy +0 −1 updated 09/04/26, 12:06

Commit message

Navigating to page id 0 (root) as an admin, e.g. in the Records
module, triggered a spurious warning "Page record array must
contain uid for breadcrumb". BackendUtility::readPageAccess(0)
returns a pseudo record array containing only "_thePath" for
admins, which carries no "uid". Such an uid-less array is a
legitimate representation of the virtual root page.

BreadcrumbFactory::forPageArray() already falls back to a null
breadcrumb context for uid-less arrays, which the
NullContextBreadcrumbProvider renders as the site root node. The
warning therefore guarded no broken behaviour and is removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Daniel Windloff +1
    • Oliver Klee +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Daniel Windloff +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Anton Danilov uploaded patch set 1 09/03/26, 12:09

  2. core-ci voted on patch set 1 V +1 09/03/26, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107747

  3. Daniel Windloff voted on patch set 1 CR +1 V +1 09/04/26, 08:06

  4. Oliver Klee voted on patch set 1 CR +1 09/04/26, 09:58

  5. Josua Vogel voted on patch set 1 CR +1 09/04/26, 11:06

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/04/26, 11:14

  7. Oli Bartsch commented on patch set 1 CR +2 V +2 09/04/26, 12:06

    Thanks.
  8. Oli Bartsch merged patch set 2 09/04/26, 12:06