Review main Merged

95604[BUGFIX] Respond with 404 for unconfigured non-zero page type

Anton Danilov CR +2 V +2 Normal +48 −18 updated 10/01/26, 08:15

Commit message

Requests carrying a non-zero ?type= parameter that does not match any
configured PAGE object currently log an error and return a 500 Internal
Server Error for every request. Looping through arbitrary type numbers
can therefore flood the log and overflow the database.

type=0 is the mandatory default page representation; when it is missing
the site cannot render at all, which is a server misconfiguration that
keeps the existing 500 response and error-level log.

Any other type requests an optional representation. If it does not
exist, the resource in that representation is simply unavailable, so
respond with the configurable 404 handling and log at debug level
instead of writing an error for each request.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1317

  1. Anton Danilov uploaded patch set 1 09/03/26, 13:02

  2. Oliver Klee updated the commit message in patch set 2 09/03/26, 13:07

  3. core-ci voted on patch set 1 V +1 09/03/26, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107754

  4. core-ci voted on patch set 2 V +1 09/03/26, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107756

  5. Mathias Brodala commented on patch set 2 09/04/26, 06:27

    PrepareTypoScriptFrontendRendering.php:257

    The log emission and request creation here and afterwards could be put into a private helper method to avoid duplication and eventual drift.
  6. Anton Danilov uploaded patch set 3 V +1 09/04/26, 09:34

  7. core-ci voted on patch set 3 V +1 09/04/26, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107847

  8. Anton Danilov commented on patch set 3 09/04/26, 09:48

    PrepareTypoScriptFrontendRendering.php:257 Reply

    Done
  9. Oliver Klee voted on patch set 3 CR +1 V +1 09/04/26, 09:57

  10. Benni Mack voted on patch set 3 CR +1 09/11/26, 21:39

  11. Rémy DANIEL voted on patch set 3 CR +1 V +1 09/17/26, 13:20

  12. Benni Mack updated the commit message in patch set 4 CR +1 V +1 09/28/26, 14:48

  13. Benni Mack voted on patch set 4 CR +1 V +1 09/28/26, 14:48

  14. Oliver Klee voted on patch set 4 CR +1 V +1 09/28/26, 14:50

  15. core-ci voted on patch set 4 V +1 09/28/26, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109432

  16. Benni Mack voted on patch set 4 CR +2 V +2 10/01/26, 08:15

  17. Benni Mack merged patch set 5 10/01/26, 08:15